Ticket #141 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Possible bug in DeferredList

Reported by: bob@redivi.com Assigned to: Bob
Priority: normal Milestone:
Component: component1 Version: 2.0
Severity: normal Keywords:
Cc:

Description (Last modified by bob@redivi.com)

After reading the source code in Async.js, i think there is a bug in DeferredList?: In line 455 > if (this.fired !== 0) { should be > if (this.fired == -1) {

Because i don't know here why use if (this.fired !== 0) { . if then, when error occured, the inner code will run again and agian. then it would raise an alreadycalled error. but this error will be wrapped to a GenericError? and been catched by outer try block, so the test can passed. I have check the corresponding twisted code, and it confirm my though.

Change History

06/28/06 20:01:38 changed by bob@redivi.com

  • description changed.

08/20/06 14:45:28 changed by therve@gmail.com

  • status changed from new to closed.
  • resolution set to fixed.

OK I fixed it in [1087]. The bug was definitely here, with fireOnOneErrback, but were swallowed. I added a small modification of the test to prevent this from happening again, but it's a bit hacky. Please confirm this is good.

10/03/06 23:37:48 changed by kkkkoaa01102006aa

  • version set to 2.0.
  • milestone set to milestone1.

Keep a good job up! phentermine mattrass handbag http://hifrien01102006.info

10/05/06 07:03:35 changed by kkkkoaa01102006aa

Keep a good job up! phentermine mattrass handbag http://hifrien01102006.info

11/18/06 15:51:23 changed by

  • milestone deleted.

Milestone milestone1 deleted