Ticket Navigation

Ticket #260 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

vertical scrolling bug

Reported by:	sky@columbia.edu	Assigned to:	somebody
Priority:	normal	Milestone:
Component:	component1	Version:
Severity:	normal	Keywords:
Cc:

Description

setting scroll:window and trying to vertically scroll makes Firefox and IE window 'hiccup' to the top. Traced it down to a code-typo: here's the patch:

Index: DragAndDrop.js
===================================================================
--- DragAndDrop.js      (revision 1308)
+++ DragAndDrop.js      (working copy)
@@ -800,7 +800,7 @@
             w = win.document.body.offsetWidth;
             h = win.document.body.offsetHeight;
         }
-        return {top: vp.x, left: vp.y, width: w, height: h};
+        return {top: vp.y, left: vp.x, width: w, height: h};
     },
 
     /** @id MochiKit.DragAndDrop.repr */

As an aside, the documentation for scroll: would be better as {{{ <code>window</code> rather than 'window' lest someone stupid (like me) think I should set it to the string value.

As another aside, line 1308 would be nicer as /AppleWebKit/ without the "'" which turns javascript-mode in emacs to make the rest of the file a string :-(

Change History

Download in other formats: