Ticket #295 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

Effect options for MochiKit.Visual.switchOff() doesn't control first effect

Reported by: cederberg@gmail.com Assigned to: somebody
Priority: normal Milestone: MochiKit 1.4
Component: component1 Version:
Severity: normal Keywords:
Cc:

Description

The MochiKit.Visual.switchOff() effect is a composite effect of an initial Opacity effect followed by a secondary Scale effect. But the options specified to the function will only affect the second effect, making it impossible to add an effect delay or control the effect queue for the initial Opacity effect.

Setting the "queue" option is broken for several other composite effects also, since many of them are created in sequence with only the first effect given the specified options object.

I think the correct solution here is to introduce a new Sequence class, similar to the existing Parallel class. And then rewrite any composite effect that uses an effect sequence to use this class instead of the "afterFinishInternal" callback. I've tried to document the cases of this that I've found so far.

Change History

03/24/08 01:58:07 changed by cederberg@gmail.com

Same problem applies to shake().

05/18/08 12:39:58 changed by cederberg@gmail.com

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [1374] and [1376].