Ticket #317 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

MochiKit.js fails to load library when asset caching is disabled (when developing)

Reported by: zubin Assigned to: cederberg@gmail.com
Priority: normal Milestone: MochiKit 1.4
Component: component1 Version:
Severity: normal Keywords:
Cc:

Description

In Ruby on Rails, asset files (javascript, images etc) have their filenames appended with a string like ?623548292 in order to disable caching when developing. This prevents MochiKit.js from loading the other files due to a regex failing on line 109.

This can be resolved by replacing line 109:

From:

if (src.match(/MochiKit.js$/)) {

To:

if (src.match(/MochiKit.js(\?\d*)?$/)) {

Hope this helps someone.

Change History

08/27/08 04:00:50 changed by cederberg@gmail.com

  • owner changed from somebody to cederberg@gmail.com.
  • status changed from new to assigned.
  • milestone set to MochiKit 1.4.

Ok, we should be more permissive when looking for the base URL. Not just allowing numbers I guess. So an even better regexp would be:

if (src.match(/MochiKit.js(\?[/]*)?$/)) {

09/17/08 01:35:19 changed by cederberg@gmail.com

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in r1396 and r1397.